Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: installation instructions re: unmet peer dependencies #1496

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

jaredbeck
Copy link
Contributor

See discussion in #1078

@jaredbeck
Copy link
Contributor Author

jaredbeck commented May 11, 2018

For example, a clean install of webpacker today (2018-05-11) according to the previous instructions results in the following:

warning "@rails/webpacker > [email protected]" has unmet peer dependency "caniuse-lite@^1.0.30000697".
warning " > [email protected]" has unmet peer dependency "webpack@^2.2.0 || ^3.0.0".
warning "webpack-dev-server > [email protected]" has unmet peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".

yarn upgrade fixes these warnings, so it might be helpful to include in the instructions

@jaredbeck
Copy link
Contributor Author

One month ping, please review

@chriscarpenter12
Copy link

Can confirm. I just started a new project and couldn't get webpack-dev-server to start. Ran yarn upgrade and it worked.

@jaredbeck jaredbeck changed the title Update installation instructions re: unmet peer dependencies Docs: installation instructions re: unmet peer dependencies Aug 7, 2018
@jaredbeck
Copy link
Contributor Author

Three month ping. This is docs-only, should be a quick review, thanks.

@gauravtiwari gauravtiwari merged commit 61d2ce1 into rails:master Aug 8, 2018
@gauravtiwari
Copy link
Member

Thanks @jaredbeck and apologies for delay :)

@jaredbeck jaredbeck deleted the patch-1 branch August 8, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants