Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown switches '--colors, --progress' - cannot start Watcher as per project documentation #994

Closed
jmdfm opened this issue Nov 3, 2017 · 3 comments

Comments

@jmdfm
Copy link

jmdfm commented Nov 3, 2017

Bundler: 1.16.0
Rails: 5.1.4
Webpacker: 3.0.2

The project readme shows under the Development section:

# watcher
./bin/webpack --colors --progress

When executing this command, it fails:

$ ./bin/webpack --colors --progress
Unknown switches '--colors, --progress'

This seems to be related to this hasty PR #843 which removed the proxying of command line switches to the underlying executable.

I'm all for allowing Environment variables to provide configuration, but surely the correct behaviour here is to have Env vars override command line switches rather than just removing command line switches altogether?

Not only is this inconvenient for me as a developer, because I have to wait for the webpacker project to implement missing environment variable analogues for existing command line switches, and this will surely always lag behind the Webpack project, but it's also breaking other projects like react-on-rails.

Please, let the Rails Doctrine apply, and give us back sharp knives.

Happy to work on a PR if consensus is reached.

@jmdfm
Copy link
Author

jmdfm commented Nov 3, 2017

Further information:

This seems like it might be two-pronged issue: it seems that Bundler 1.16.0 is responsible for the 'unknown switches' message, but even if it wasn't the command line arguments still are not being proxied through to the underlying executable in webpacker.

@jmdfm
Copy link
Author

jmdfm commented Nov 3, 2017

Opened an issue with Bundler also: rubygems/bundler#6149

@jmdfm
Copy link
Author

jmdfm commented Nov 3, 2017

Closing this issue as it's totally Bundler that's causing the problem. Sorry folks.

@jmdfm jmdfm closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant