Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylesheet_pack_tag method #79

Closed
kruczjak opened this issue Feb 2, 2017 · 6 comments
Closed

Add stylesheet_pack_tag method #79

kruczjak opened this issue Feb 2, 2017 · 6 comments

Comments

@kruczjak
Copy link

kruczjak commented Feb 2, 2017

Hi :)

I think it would be also nice to add possibility to require css that is built in webpack.
It can also have digest string in filename.

https://github.com/kruczjak/liveread/blob/master/app/views/layouts/application.html.erb#L7

@merqlove
Copy link
Contributor

merqlove commented Feb 4, 2017

but you anyway have sprockets)

@kruczjak
Copy link
Author

kruczjak commented Feb 4, 2017

@merqlove Yes :), but with webpack, you can e.g. extract css that's in .js or .ts sources to standalone .css file. (https://github.com/webpack-contrib/extract-text-webpack-plugin)

@merqlove
Copy link
Contributor

merqlove commented Feb 4, 2017

i'm agree. here also can be anything not only stylesheet. resource_pack_tag :)

@dimroc
Copy link

dimroc commented Feb 7, 2017

It would be particularly useful when used alongside Vue single file components:
https://github.com/vuejs/vueify

@gauravtiwari
Copy link
Member

gauravtiwari commented Feb 28, 2017

@kruczjak We are tracking this issue here (#109) now, along with how to handle other assets. Please could you close this issue as it's duplicate.

@kruczjak
Copy link
Author

Yes, of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants