Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task webpacker:install actually upgrades installation #2379

Closed
DavidHernandez opened this issue Nov 27, 2019 · 1 comment
Closed

Task webpacker:install actually upgrades installation #2379

DavidHernandez opened this issue Nov 27, 2019 · 1 comment

Comments

@DavidHernandez
Copy link
Contributor

Hi,

When executing the task webpacker:install, the task does not install the webpacker version specified on your Gemfile, but instead, installs the last version, which in some cases, breaks the functionality:

if Webpacker::VERSION =~ /^[0-9]+\.[0-9]+\.[0-9]+$/
  say "Installing all JavaScript dependencies [#{Webpacker::VERSION}]"
  run "yarn add @rails/webpacker"

The printed message is missleading, as it says that will install the javascript dependencies for your Webpacker::VERSION, but then, it just goes and does a yarn add webpacker that will install the last available version.

The command should always respect the specified version, to prevent breaking environments.

I will open a Pull Request to fix this issue.

Regards,
David.

@DavidHernandez
Copy link
Contributor Author

I guess this can be closed, as the PR has been already merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants