Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for compression with Brotli #2089

Closed
guillaumebriday opened this issue May 8, 2019 · 4 comments
Closed

Adding support for compression with Brotli #2089

guillaumebriday opened this issue May 8, 2019 · 4 comments

Comments

@guillaumebriday
Copy link
Member

Hey ! 👋

As far as I know, Webpacker is using https://github.com/webpack-contrib/compression-webpack-plugin to generate the gzip compressed files.

This plugin added the support for Brotli webpack-contrib/compression-webpack-plugin#119 and I think it's could be great to add it in Webpacker

Adding he proper documentation for nginx headers and an opt-out configuration in the webpacker.yml could be great too.

What do you think ? I could open a PR if you're ok with this feature !

Thank you in advance

@aried3r
Copy link
Contributor

aried3r commented Jun 3, 2019

Hey @guillaumebriday, I really like your idea. What do you think about submitting a PR were this can be discussed further? I think once there's a PR it becomes more real and others can maybe already use it in their configs.

As this feature is only available after node.js 11.7.0 and later this should only be the default for compatible setups, since webpacker (so far) works with node.js 6 and above, while 10 is the currently active LTS release and 11 is EOL. https://github.com/nodejs/Release#release-schedule

What do you think? :)

@guillaumebriday
Copy link
Member Author

Ok I'll will try to open a PR soon,

and yes, this should be the default only for compatible systems !

Thank you

@julianrubisch
Copy link

I think this issue can be closed?

@guillaumebriday
Copy link
Member Author

Sure ! Thanks @clupprich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants