Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the webpack dependencies move to devDependencies? #165

Closed
mortyccp opened this issue Mar 9, 2017 · 6 comments
Closed

Should the webpack dependencies move to devDependencies? #165

mortyccp opened this issue Mar 9, 2017 · 6 comments

Comments

@mortyccp
Copy link

mortyccp commented Mar 9, 2017

Currently, the generated package.json of the MV* templates, webpack dependencies are include in
dependencies section but not devDependencies. It is more suitable to move those to devDependencies ?

@dleavitt
Copy link
Contributor

dleavitt commented Mar 9, 2017

negative, see: #117

@gauravtiwari
Copy link
Member

gauravtiwari commented Mar 9, 2017

@soapsign and this one too - #160

@gauravtiwari
Copy link
Member

Feel free to close the issue if that answers your question :)

@mortyccp
Copy link
Author

mortyccp commented Mar 9, 2017

Background: right now we're putting build deps under devDependencies even though they're required in production.
If I need to deploy to server without node, can I bundle using webpack beforehand?

@p0wl
Copy link
Contributor

p0wl commented Mar 9, 2017

yes, you can. run rake webpacker:compile and ensure that the files in public/packs are deployed to your server.

@mortyccp
Copy link
Author

mortyccp commented Mar 9, 2017

OK. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants