Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn integrity check should be silent when it passes #1169

Closed
dhh opened this issue Jan 11, 2018 · 4 comments
Closed

Yarn integrity check should be silent when it passes #1169

dhh opened this issue Jan 11, 2018 · 4 comments
Assignees
@gauravtiwari

Comments

@dhh
Copy link
Member

dhh commented Jan 11, 2018 

$ r c
=> Booting Rails
yarn check v1.3.2
success Folder in sync.
✨  Done in 0.09s.
Loading development environment (Rails 5.2.0.beta2)
irb(main):001:0>

Three lines for the Yarn integrity check every time it runs in development mode is too noisy. It should be silent unless it fails.
@gauravtiwari
Copy link
Member

Will take a look 👍

@guilleiguaran
Copy link
Member

guilleiguaran commented Jan 12, 2018 •
edited
Loading

Wasn't this done in #1131? if that is the case I think we just need to cut a new release of the gem!!

@dhh
Copy link
Member Author

dhh commented Jan 12, 2018

Ha. Yes it is.

@dhh dhh closed this as completed Jan 12, 2018
@gauravtiwari
Copy link
Member

Ahh yes, totally forgot. Will make a new release over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravtiwari gauravtiwari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhh @guilleiguaran @gauravtiwari