From d05068209544acb8cf32f10d6b722b72beed3314 Mon Sep 17 00:00:00 2001 From: Sampson Crowley Date: Tue, 22 Sep 2020 13:40:24 -0600 Subject: [PATCH] Fix duplicated test names for image pack helpers and use github relative links in docs (#2737) --- docs/assets.md | 2 +- docs/es6.md | 2 +- docs/testing.md | 2 +- test/helper_test.rb | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/assets.md b/docs/assets.md index 44b2852b1..d6b5f2a3a 100644 --- a/docs/assets.md +++ b/docs/assets.md @@ -132,4 +132,4 @@ require.context('../images', true) <% # => %> ``` -Note you need to add a `media/` prefix (not `/media/`) to any subfolder structure you might have in `app/javascript`. See more examples in the [tests](https://github.com/rails/webpacker/blob/0b86cadb5ed921e2c1538382e72a236ec30a5d97/test/helper_test.rb#L37). +Note you need to add a `media/` prefix (not `/media/`) to any subfolder structure you might have in `app/javascript`. See more examples in the [tests](/test/helper_test.rb#L37). diff --git a/docs/es6.md b/docs/es6.md index f17ca0443..7ea38c3f2 100644 --- a/docs/es6.md +++ b/docs/es6.md @@ -42,7 +42,7 @@ The comment you see above (`/* webpackChunkName */`) is not arbitrary, it is one **Warning**: You should not attempt to dynamically load anything from your `packs/` folder. Instead, try to make your `pack` scripts a hub from which you dynamically load `non-pack` scripts. - [Docs for using magic comments](https://webpack.js.org/api/module-methods/#magic-comments) -- [Docs for configuring `splitChunks` in webpacker](https://github.com/rails/webpacker/blob/master/docs/webpack.md#add-splitchunks-webpack-v4). +- [Docs for configuring `splitChunks` in webpacker](/docs/webpack.md#add-splitchunks-webpack-v4). - [Docs for using dynamic `import()`](https://webpack.js.org/guides/code-splitting#dynamic-imports). ## Module import vs require() diff --git a/docs/testing.md b/docs/testing.md index 07f1c71bf..b9af3ca6c 100644 --- a/docs/testing.md +++ b/docs/testing.md @@ -140,7 +140,7 @@ config.public_file_server.enabled = true Webpacker ships with three javascript configuration files: `test.js`, `development.js`, and `production.js`. The `NODE_ENV` environment variable determines which config will be used. `NODE_ENV` is -independent of `RAILS_ENV` and is set to `development` by [default](https://github.com/rails/webpacker/blob/bf278f9787704ed0f78038ad7d36c008abc2edfd/lib/install/bin/webpack#L4). +independent of `RAILS_ENV` and is set to `development` by [default](/lib/install/bin/webpack#L4). This means that `rails test` or `rspec` will use `development.js` by default, _not_ `test.js`. diff --git a/test/helper_test.rb b/test/helper_test.rb index 1bb259fbc..60ceb119a 100644 --- a/test/helper_test.rb +++ b/test/helper_test.rb @@ -34,7 +34,7 @@ def test_asset_pack_url end end - def test_asset_pack_path + def test_image_pack_path assert_equal "/packs/application-k344a6d59eef8632c9d1.png", image_pack_path("application.png") assert_equal "/packs/media/images/image-c38deda30895059837cf.jpg", image_pack_path("image.jpg") assert_equal "/packs/media/images/image-c38deda30895059837cf.jpg", image_pack_path("media/images/image.jpg") @@ -42,7 +42,7 @@ def test_asset_pack_path assert_equal "/packs/media/images/nested/image-c38deda30895059837cf.jpg", image_pack_path("media/images/nested/image.jpg") end - def test_asset_pack_url + def test_image_pack_url assert_equal "https://example.com/packs/application-k344a6d59eef8632c9d1.png", image_pack_url("application.png") assert_equal "https://example.com/packs/media/images/image-c38deda30895059837cf.jpg", image_pack_url("image.jpg") assert_equal "https://example.com/packs/media/images/image-c38deda30895059837cf.jpg", image_pack_url("media/images/image.jpg")