From 716a45f70caaec5881756f68e5f5592beaf5a24e Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sat, 5 Dec 2015 21:05:09 +0200 Subject: [PATCH 01/12] Don't require sprockets as a dependency We don't really need sprockets, as we abuse actionview for our assets. --- web-console.gemspec | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/web-console.gemspec b/web-console.gemspec index 0cd78171..c579da01 100644 --- a/web-console.gemspec +++ b/web-console.gemspec @@ -17,9 +17,8 @@ Gem::Specification.new do |s| rails_version = ">= 4.0" - s.add_dependency "railties", rails_version - s.add_dependency "activemodel", rails_version - s.add_dependency "sprockets-rails", ">= 2.0", "< 4.0" + s.add_dependency "railties", rails_version + s.add_dependency "activemodel", rails_version s.add_dependency "debug_inspector" # We need those for the testing application to run. From 839e42166930694baf8863d4c1c8d9692e99ad9c Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 6 Dec 2015 13:01:23 +0200 Subject: [PATCH 02/12] Clean up unneeded test dependencies --- Gemfile | 7 ------- test/dummy/config/application.rb | 4 +++- test/dummy/config/environments/development.rb | 11 ----------- test/dummy/config/environments/production.rb | 13 ------------- test/dummy/config/environments/test.rb | 5 ----- test/dummy/db/schema.rb | 16 ---------------- web-console.gemspec | 4 ---- 7 files changed, 3 insertions(+), 57 deletions(-) delete mode 100644 test/dummy/db/schema.rb diff --git a/Gemfile b/Gemfile index f5dbcdaa..577d1b91 100644 --- a/Gemfile +++ b/Gemfile @@ -4,19 +4,12 @@ gemspec gem 'rails', github: 'rails/rails' gem 'arel', github: 'rails/arel' -gem 'sprockets', github: 'rails/sprockets' -gem 'sprockets-rails', github: 'rails/sprockets-rails' gem 'rack', github: 'rack/rack' platforms :jruby do - gem 'activerecord-jdbcsqlite3-adapter' gem 'binding_of_caller', '0.7.3.pre1' end -platforms :ruby do - gem 'sqlite3' -end - group :test do gem 'rake' gem 'mocha', require: false diff --git a/test/dummy/config/application.rb b/test/dummy/config/application.rb index 081fd93b..83eab38e 100644 --- a/test/dummy/config/application.rb +++ b/test/dummy/config/application.rb @@ -1,6 +1,8 @@ require File.expand_path('../boot', __FILE__) -require 'rails/all' +require "active_model/railtie" +require "action_controller/railtie" +require "action_view/railtie" Bundler.require(*Rails.groups) require 'web_console' diff --git a/test/dummy/config/environments/development.rb b/test/dummy/config/environments/development.rb index 9d26e125..b16dd2fb 100644 --- a/test/dummy/config/environments/development.rb +++ b/test/dummy/config/environments/development.rb @@ -13,17 +13,6 @@ config.consider_all_requests_local = true config.action_controller.perform_caching = false - # Don't care if the mailer can't send. - config.action_mailer.raise_delivery_errors = false - # Print deprecation notices to the Rails logger. config.active_support.deprecation = :log - - # Raise an error on page load if there are pending migrations - config.active_record.migration_error = :page_load - - # Debug mode disables concatenation and preprocessing of assets. - # This option may cause significant delays in view rendering with a large - # number of complex assets. - config.assets.debug = true end diff --git a/test/dummy/config/environments/production.rb b/test/dummy/config/environments/production.rb index b690b1cf..dc33932f 100644 --- a/test/dummy/config/environments/production.rb +++ b/test/dummy/config/environments/production.rb @@ -22,19 +22,6 @@ # Disable Rails's static asset server (Apache or nginx will already do this). config.serve_static_assets = false - # Compress JavaScripts and CSS. - config.assets.js_compressor = :uglifier - # config.assets.css_compressor = :sass - - # Do not fallback to assets pipeline if a precompiled asset is missed. - config.assets.compile = false - - # Generate digests for assets URLs. - config.assets.digest = true - - # Version of your assets, change this if you want to expire all your assets. - config.assets.version = '1.0' - # Specifies the header that your server uses for sending files. # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx diff --git a/test/dummy/config/environments/test.rb b/test/dummy/config/environments/test.rb index 3f17a67a..897205ee 100644 --- a/test/dummy/config/environments/test.rb +++ b/test/dummy/config/environments/test.rb @@ -22,11 +22,6 @@ # Disable request forgery protection in test environment. config.action_controller.allow_forgery_protection = false - # Tell Action Mailer not to deliver emails to the real world. - # The :test delivery method accumulates sent emails in the - # ActionMailer::Base.deliveries array. - config.action_mailer.delivery_method = :test - # Print deprecation notices to the stderr. config.active_support.deprecation = :stderr diff --git a/test/dummy/db/schema.rb b/test/dummy/db/schema.rb deleted file mode 100644 index 4dfbb168..00000000 --- a/test/dummy/db/schema.rb +++ /dev/null @@ -1,16 +0,0 @@ -# encoding: UTF-8 -# This file is auto-generated from the current state of the database. Instead -# of editing this file, please use the migrations feature of Active Record to -# incrementally modify your database, and then regenerate this schema definition. -# -# Note that this schema.rb definition is the authoritative source for your -# database schema. If you need to create the application database on another -# system, you should be using db:schema:load, not running all the migrations -# from scratch. The latter is a flawed and unsustainable approach (the more migrations -# you'll amass, the slower it'll run and the greater likelihood for issues). -# -# It's strongly recommended that you check this file into your version control system. - -ActiveRecord::Schema.define(version: 0) do - -end diff --git a/web-console.gemspec b/web-console.gemspec index c579da01..b85a8c5a 100644 --- a/web-console.gemspec +++ b/web-console.gemspec @@ -20,8 +20,4 @@ Gem::Specification.new do |s| s.add_dependency "railties", rails_version s.add_dependency "activemodel", rails_version s.add_dependency "debug_inspector" - - # We need those for the testing application to run. - s.add_development_dependency "actionmailer", rails_version - s.add_development_dependency "activerecord", rails_version end From 4f6b6cf3877d2b261570c75ade5650c5cec7aece Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 6 Dec 2015 13:06:08 +0200 Subject: [PATCH 03/12] Turn on the development only mode by default This will warn folks trying to use web-console outside of the development mode. --- lib/web_console/railtie.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/web_console/railtie.rb b/lib/web_console/railtie.rb index 2ba61391..6b54feae 100644 --- a/lib/web_console/railtie.rb +++ b/lib/web_console/railtie.rb @@ -5,9 +5,7 @@ class Railtie < ::Rails::Railtie config.web_console = ActiveSupport::OrderedOptions.new config.web_console.whitelisted_ips = %w( 127.0.0.1 ::1 ) - # See rails/web-console#150 and rails/rails#20319. Revert when Ruby on - # Rails 4.2.4 is released. - config.web_console.development_only = false + config.web_console.development_only = true initializer 'web_console.initialize' do require 'web_console/extensions' From 8142af4f9c4d47c95013d578b92908b510840e72 Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 6 Dec 2015 13:37:27 +0200 Subject: [PATCH 04/12] Drop testing support for Rails 4 We can target Rails 5 for web-console 3. --- .travis.yml | 3 +-- gemfiles/Gemfile-4-0-stable | 20 -------------------- gemfiles/Gemfile-4-1-stable | 20 -------------------- gemfiles/Gemfile-4-2-stable | 20 -------------------- 4 files changed, 1 insertion(+), 62 deletions(-) delete mode 100644 gemfiles/Gemfile-4-0-stable delete mode 100644 gemfiles/Gemfile-4-1-stable delete mode 100644 gemfiles/Gemfile-4-2-stable diff --git a/.travis.yml b/.travis.yml index 4352cc6d..feeed703 100644 --- a/.travis.yml +++ b/.travis.yml @@ -24,8 +24,7 @@ script: matrix: include: - - gemfile: gemfiles/Gemfile-4-0-stable - env: TEST_SUITE=test:templates + - env: TEST_SUITE=test:templates rvm: 2.2.2 allow_failures: - rvm: ruby-head diff --git a/gemfiles/Gemfile-4-0-stable b/gemfiles/Gemfile-4-0-stable deleted file mode 100644 index 791c81ed..00000000 --- a/gemfiles/Gemfile-4-0-stable +++ /dev/null @@ -1,20 +0,0 @@ -source 'https://rubygems.org' - -gemspec path: '..' - -gem 'rails', github: 'rails/rails', branch: '4-0-stable' - -platforms :jruby do - gem 'activerecord-jdbcsqlite3-adapter' - gem 'binding_of_caller', '0.7.3.pre1' -end - -platforms :ruby do - gem 'sqlite3' -end - -group :test do - gem 'rake' - gem 'mocha', require: false - gem 'simplecov', require: false -end diff --git a/gemfiles/Gemfile-4-1-stable b/gemfiles/Gemfile-4-1-stable deleted file mode 100644 index c76fe816..00000000 --- a/gemfiles/Gemfile-4-1-stable +++ /dev/null @@ -1,20 +0,0 @@ -source 'https://rubygems.org' - -gemspec path: '..' - -gem 'rails', github: 'rails/rails', branch: '4-1-stable' - -platforms :jruby do - gem 'activerecord-jdbcsqlite3-adapter' - gem 'binding_of_caller', '0.7.3.pre1' -end - -platforms :ruby do - gem 'sqlite3' -end - -group :test do - gem 'rake' - gem 'mocha', require: false - gem 'simplecov', require: false -end diff --git a/gemfiles/Gemfile-4-2-stable b/gemfiles/Gemfile-4-2-stable deleted file mode 100644 index 9e4cac3e..00000000 --- a/gemfiles/Gemfile-4-2-stable +++ /dev/null @@ -1,20 +0,0 @@ -source 'https://rubygems.org' - -gemspec path: '..' - -gem 'rails', github: 'rails/rails', branch: '4-2-stable' - -platforms :jruby do - gem 'activerecord-jdbcsqlite3-adapter' - gem 'binding_of_caller', '0.7.3.pre1' -end - -platforms :ruby do - gem 'sqlite3' -end - -group :test do - gem 'rake' - gem 'mocha', require: false - gem 'simplecov', require: false -end From ca3b38a0c8c3ecd97f6e97214015877f015c3b0b Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 6 Dec 2015 16:27:56 +0200 Subject: [PATCH 05/12] Remove JRuby support for 3.0 I want to revisit this, but I have to extract the hacky bindex implementation for JRuby 9k. Will do this for 3.1 since we never saw that much JRuby usage for the effort we put into supporting it. I still want to support it, it's just not a priority at the moment. --- lib/web_console/integration.rb | 2 - lib/web_console/integration/jruby.rb | 111 --------------------------- 2 files changed, 113 deletions(-) delete mode 100644 lib/web_console/integration/jruby.rb diff --git a/lib/web_console/integration.rb b/lib/web_console/integration.rb index 04cf85cd..44844605 100644 --- a/lib/web_console/integration.rb +++ b/lib/web_console/integration.rb @@ -26,8 +26,6 @@ def bindings case RUBY_ENGINE when 'rbx' require 'web_console/integration/rubinius' -when 'jruby' - require 'web_console/integration/jruby' when 'ruby' require 'web_console/integration/cruby' end diff --git a/lib/web_console/integration/jruby.rb b/lib/web_console/integration/jruby.rb deleted file mode 100644 index 76e4be29..00000000 --- a/lib/web_console/integration/jruby.rb +++ /dev/null @@ -1,111 +0,0 @@ -require 'English' -require 'active_support/core_ext/string/strip' - -java_import org.jruby.RubyInstanceConfig - -module WebConsole - module JRuby - class << self - # Returns whether JRuby is ran in interpreted mode. - def interpreted_mode? - compile_mode = ::JRuby.runtime.instance_config.compile_mode - interpreted_mode = RubyInstanceConfig::CompileMode::OFF - - compile_mode == interpreted_mode - end - - # A proc to be used in Kernel#set_trace_func. - # - # It sets Exception#bindings for an error with all the bindings the - # current ThreadContext contains. - def set_exception_bindings_trace_func - proc do |event, file, line, id, binding, classname| - case event - when 'raise' - if $ERROR_INFO.bindings.empty? - # binding_of_caller will generate an improperly built binding at - # caller[1]. Every call to a non existent method, constant or a - # local variable will result in a Java NullPointerException. - # - # The binding that Kernel#set_trace_func is giving us is properly - # built, so we can use in place of the broken one. - bindings = ::Kernel.binding.callers.drop(2).unshift(binding) - $ERROR_INFO.instance_variable_set(:@bindings, bindings) - end - end - end - end - end - - # A fake binding for JRuby in non interpreted mode. - # - # It won't actually evaluate any code, rather it will tell the user how to - # enable interpreted mode. - class FakeJRubyBinding - TURN_ON_INTERPRETED_MODE_TEXT = <<-END.strip_heredoc - JRuby needs to run in interpreted mode for introspection support. - - To turn on interpreted mode, put -J-Djruby.compile.mode=OFF in the - JRUBY_OPTS environment variable. - END - - def TURN_ON_INTERPRETED_MODE_TEXT.inspect - self - end - - TURN_ON_INTERPRETED_MODE_TEXT.freeze - - def eval(*) - TURN_ON_INTERPRETED_MODE_TEXT - end - end - - # A fake array of FakeJRubyBinding objects. - # - # It is used in Exception#bindings to make sure that when users switch - # bindings on the UI, they get a FakeJRubyBinding notifying them what to do - # if they want introspection. - class FakeJRubyBindingsArray < Array - def [](*) - FakeJRubyBinding.new - end - - # For Kernel#Array and other implicit conversion API. JRuby expects it to - # return an object that is_a? an Array. This is the reasoning of - # FakeJRubyBindingsArray being a subclass of Array. - def to_ary - self - end - end - end -end - -if WebConsole::JRuby.interpreted_mode? - ::Exception.class_eval do - def bindings - @bindings || [] - end - end - - # Kernel#set_trace_func will complain about not being able to capture all the - # events without the JRuby --debug flag. - silence_warnings do - set_trace_func WebConsole::JRuby.set_exception_bindings_trace_func - end -else - ::Exception.class_eval do - def bindings - WebConsole::JRuby::FakeJRubyBindingsArray.new - end - end - - ::Binding.class_eval do - def of_caller(*) - WebConsole::JRuby::FakeJRubyBinding.new - end - - def callers - WebConsole::JRuby::FakeJRubyBindingsArray.new - end - end -end From 55ead903916978a2850d08d80b333113f565cb0d Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 6 Dec 2015 17:06:42 +0200 Subject: [PATCH 06/12] Update the README for Rails 5 --- README.markdown | 60 +++++++++++++++++++------------------------------ 1 file changed, 23 insertions(+), 37 deletions(-) diff --git a/README.markdown b/README.markdown index 174bd51a..b33a56ad 100644 --- a/README.markdown +++ b/README.markdown @@ -1,9 +1,6 @@

Documentation for: - v2.0.0 - v2.1.0 - v2.1.1 - v2.1.2 + v1.0.4 v2.1.3

@@ -23,12 +20,12 @@ _Web Console_ is a debugging tool for your Ruby on Rails applications. ## Installation -_Web Console_ is meant to work as a Rails plugin. To install it in your current +_Web Console_ is meant to work as a Rails 5 plugin. To install it in your current application, add the following to your `Gemfile`. ```ruby group :development do - gem 'web-console', '~> 2.0' + gem 'web-console', '~> 3.0' end ``` @@ -37,35 +34,9 @@ restart your server for the _Web Console_ to kick in. ## Runtime -_Web Console_ uses [John Mair]'s [binding_of_caller] to spawn a console in a -specific binding. This comes at the price of limited Ruby runtime support. - ### CRuby -CRuby 1.9.2 and below is **not** supported. - -### JRuby - -JRuby needs to run in interpreted mode. You can enable it by: - -```bash -export JRUBY_OPTS=-J-Djruby.compile.mode=OFF - -# If you run JRuby 1.7.12 and above, you can use: -export JRUBY_OPTS=--dev -``` - -An unstable version of [binding_of_caller] is needed as the latest stable one -won't compile on _JRuby_. To install it, put the following in your application -`Gemfile`: - -```ruby -group :development do - gem 'binding_of_caller', '0.7.3.pre1' -end -``` - -Only _JRuby_ 1.7, is supported (no JRuby 9K support at the moment). +CRuby 2.2 and below is **not** supported. ### Rubinius @@ -213,12 +184,28 @@ end Make sure you configuration lives in `config/environments/development.rb`. +### What happened to th JRuby support? + +Rails 5 doesn't support JRuby well enough. As soon as the Rails support gets +better we'll look into re-introducing the JRuby support. + +### What about Rails 4.2? + +The `2.x` releases will keep on supporting Rails 4.2. You can lock the versions +with: + +```ruby +group :development do + gem 'web-console', '~> 2.0' +end +``` + ## Credits -* Shoutout to [Charlie Somerville] for [better_errors] and [this] code. -* Kudos to [John Mair] for [binding_of_caller]. +* Shoutout to [Charlie Somerville] for [better_errors]. +* Kudos to [John Mair] for [debug_inspector]. * Thanks to [Charles Oliver Nutter] for all the _JRuby_ feedback. -* Hugs and kisses to all of our [contributors]. +* Hugs and kisses to all of our [contributors]! [better_errors]: https://github.com/charliesome/better_errors [binding_of_caller]: https://github.com/banister/binding_of_caller @@ -226,6 +213,5 @@ Make sure you configuration lives in `config/environments/development.rb`. [John Mair]: https://github.com/banister [Charles Oliver Nutter]: https://github.com/headius [templates]: https://github.com/rails/web-console/tree/master/lib/web_console/templates -[this]: https://github.com/rails/web-console/blob/master/lib/web_console/integration/cruby.rb#L20-L32 [rvt]: https://github.com/gsamokovarov/rvt [contributors]: https://github.com/rails/web-console/graphs/contributors From 6cfeba6c0e577a8b931de460a869c8b3bacd902d Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 6 Dec 2015 20:50:38 +0200 Subject: [PATCH 07/12] Drop the unneeded config.web_console.development_only --- lib/web_console/railtie.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/web_console/railtie.rb b/lib/web_console/railtie.rb index 6b54feae..02ea3003 100644 --- a/lib/web_console/railtie.rb +++ b/lib/web_console/railtie.rb @@ -5,8 +5,6 @@ class Railtie < ::Rails::Railtie config.web_console = ActiveSupport::OrderedOptions.new config.web_console.whitelisted_ips = %w( 127.0.0.1 ::1 ) - config.web_console.development_only = true - initializer 'web_console.initialize' do require 'web_console/extensions' From 5445eca79a2ff3b6d61181d844d5b261ef47c57e Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 6 Dec 2015 20:52:12 +0200 Subject: [PATCH 08/12] Grammar fix in a web-console development only abort message --- lib/web_console/railtie.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/web_console/railtie.rb b/lib/web_console/railtie.rb index 02ea3003..c594beca 100644 --- a/lib/web_console/railtie.rb +++ b/lib/web_console/railtie.rb @@ -20,7 +20,7 @@ class Railtie < ::Rails::Railtie initializer 'web_console.development_only' do unless (config.web_console.development_only == false) || Rails.env.development? abort <<-END.strip_heredoc - Web Console is activated in the #{Rails.env} environment, which is + Web Console is activated in the #{Rails.env} environment. This is usually a mistake. To ensure it's only activated in development mode, move it to the development group of your Gemfile: From 36b82efd5012795467530f895af5e7701c73e604 Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 6 Dec 2015 20:53:45 +0200 Subject: [PATCH 09/12] Enforce Ruby 2.2.3 on travis tests --- .travis.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index feeed703..27147e7e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,7 @@ language: ruby rvm: - - 2.2 + - 2.2.3 - ruby-head - rbx-2 - jruby @@ -16,16 +16,10 @@ env: sudo: false -before_script: - - RAILS_ENV=test bundle exec rake --rakefile=test/dummy/Rakefile db:setup - script: - bundle exec rake ${TEST_SUITE} matrix: - include: - - env: TEST_SUITE=test:templates - rvm: 2.2.2 allow_failures: - rvm: ruby-head - rvm: rbx-2 From 63e139d5365155b3aae9cf974a4a96cb551b42c8 Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 13 Dec 2015 17:10:09 +0100 Subject: [PATCH 10/12] Support Rails 4.2 even though I won't advertise it I was thinking of making two releases, but I'll keep this one Rails 4.2 compatible. However, I won't support Ruby 1.9.3. --- lib/web_console/extensions.rb | 9 ++++++--- web-console.gemspec | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/web_console/extensions.rb b/lib/web_console/extensions.rb index 1599107f..834c90d8 100644 --- a/lib/web_console/extensions.rb +++ b/lib/web_console/extensions.rb @@ -1,17 +1,20 @@ ActionDispatch::DebugExceptions.class_eval do def render_exception_with_web_console(request, exception) render_exception_without_web_console(request, exception).tap do - backtrace_cleaner = request.env['action_dispatch.backtrace_cleaner'] + # Retain superficial Rails 4.2 compatibility. + env = Hash === request ? request : request.env + + backtrace_cleaner = env['action_dispatch.backtrace_cleaner'] error = ActionDispatch::ExceptionWrapper.new(backtrace_cleaner, exception).exception # Get the original exception if ExceptionWrapper decides to follow it. - request.env['web_console.exception'] = error + env['web_console.exception'] = error # ActionView::Template::Error bypass ExceptionWrapper original # exception following. The backtrace in the view is generated from # reaching out to original_exception in the view. if error.is_a?(ActionView::Template::Error) - request.env['web_console.exception'] = error.original_exception + env['web_console.exception'] = error.original_exception end end end diff --git a/web-console.gemspec b/web-console.gemspec index b85a8c5a..71f2ed84 100644 --- a/web-console.gemspec +++ b/web-console.gemspec @@ -15,7 +15,7 @@ Gem::Specification.new do |s| s.required_ruby_version = '>= 2.2.2' - rails_version = ">= 4.0" + rails_version = ">= 4.2" s.add_dependency "railties", rails_version s.add_dependency "activemodel", rails_version From 7686bb4f33a97ed87e24c6ef6bb59f2f59dad08e Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 13 Dec 2015 17:14:20 +0100 Subject: [PATCH 11/12] Pass over the README for 3.0 --- README.markdown | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/README.markdown b/README.markdown index b33a56ad..56cc41cd 100644 --- a/README.markdown +++ b/README.markdown @@ -20,7 +20,7 @@ _Web Console_ is a debugging tool for your Ruby on Rails applications. ## Installation -_Web Console_ is meant to work as a Rails 5 plugin. To install it in your current +_Web Console_ is meant to work as a Rails plugin. To install it in your current application, add the following to your `Gemfile`. ```ruby @@ -184,22 +184,6 @@ end Make sure you configuration lives in `config/environments/development.rb`. -### What happened to th JRuby support? - -Rails 5 doesn't support JRuby well enough. As soon as the Rails support gets -better we'll look into re-introducing the JRuby support. - -### What about Rails 4.2? - -The `2.x` releases will keep on supporting Rails 4.2. You can lock the versions -with: - -```ruby -group :development do - gem 'web-console', '~> 2.0' -end -``` - ## Credits * Shoutout to [Charlie Somerville] for [better_errors]. @@ -208,7 +192,7 @@ end * Hugs and kisses to all of our [contributors]! [better_errors]: https://github.com/charliesome/better_errors -[binding_of_caller]: https://github.com/banister/binding_of_caller +[debug_inspector]: https://github.com/banister/debug_inspector [Charlie Somerville]: https://github.com/charliesome [John Mair]: https://github.com/banister [Charles Oliver Nutter]: https://github.com/headius From e023a93ed3fe5b1f86d37860a446defa7ad9736f Mon Sep 17 00:00:00 2001 From: Genadi Samokovarov Date: Sun, 13 Dec 2015 17:16:48 +0100 Subject: [PATCH 12/12] Drop binding_of_caller for JRuby --- Gemfile | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Gemfile b/Gemfile index 577d1b91..5c85600c 100644 --- a/Gemfile +++ b/Gemfile @@ -6,10 +6,6 @@ gem 'rails', github: 'rails/rails' gem 'arel', github: 'rails/arel' gem 'rack', github: 'rack/rack' -platforms :jruby do - gem 'binding_of_caller', '0.7.3.pre1' -end - group :test do gem 'rake' gem 'mocha', require: false