Fix thread safety of Sprockets::CachedEnvironment and Sprockets::Cache::MemoryStore #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unfortunately this on its own does not work yet due to Sprockets recursively calling Sprockets::CachedEnvironment#load. * Reproduce the recursion issue with: bundle exec bin/sprockets -I test/fixtures/asset $PWD/test/fixtures/asset/application.js
eregon
force-pushed
the
thread-safe-CachedEnvironment
branch
from
0ec1993
to
b3c69c0
Compare
* This does not hold any lock while computing the missing key, so avoids the problem of having a lock while recursing when using #compute_if_absent. * As the docs say: https://ruby-concurrency.github.io/concurrent-ruby/master/Concurrent/Map.html#fetch_or_store-instance_method "The store can overwrite other concurrently stored value.". Which was already possibly before, Hash#fetch does not have the guarantee to execute the block only once per key, even on CRuby.
eregon
force-pushed
the
thread-safe-CachedEnvironment
branch
from
b3c69c0
to
9d461f1
Compare
eregon
changed the title
* This should help catching concurrency issues much faster. * Notably, the two issues of rails#772 reproduce by running the test suite on TruffleRuby. * Skip tests which do not pass yet on TrufffleRuby. oracle/truffleruby#2810
* host is "" instead of nil, following the upstream change: ruby/uri@81263c9
eregon
force-pushed
the
thread-safe-CachedEnvironment
branch
from
0826f83
to
39490de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772