Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batching of transactions for opening a channel & depositing #400

Closed
loredanacirstea opened this issue Jan 7, 2019 · 3 comments
Closed
Assignees
Labels
component:CORE Raiden Network Core Smart Contracts enhancement New feature or request Needs redeployment The issue/PR results in a breaking change in the precompiled data in `contracts.json` ->redeployment P4: good_to_have
Milestone

Comments

@loredanacirstea
Copy link
Contributor

We can have a wrapper for opening a channel and depositing. This lowers the waiting time for the user, as it reduces the number of on-chain transactions from 2 to 1.

@loredanacirstea loredanacirstea added the P3 keeping somebody waiting possibly label Jan 7, 2019
@loredanacirstea loredanacirstea added this to the Ithaca milestone Jan 7, 2019
@loredanacirstea loredanacirstea added Needs redeployment The issue/PR results in a breaking change in the precompiled data in `contracts.json` ->redeployment component:CORE Raiden Network Core Smart Contracts labels Jan 9, 2019
@hackaugusto
Copy link
Contributor

This not only improves the wait time, but it also simplifies the handling of smart contract proxies. Specifically the ERC20 token networks a client has to:

  • Use a global lock to synchronize usage to a token and to its corresponding token network. This is necessary because calls to approve are not idempotent, and concurrent calls will race, making one of them fail.
  • It's necessary to validate multiple conditions before doing a deposit, on both the token and the token network state, and the interactions lead to cumbersome code.

reference

@pirapira
Copy link
Contributor

Note: consider implementing the proxy in a separate contract. We are close to hitting the deployed codesize limit.

@pirapira pirapira removed this from the Ithaca milestone Jan 31, 2019
@pirapira pirapira added enhancement New feature or request P4: good_to_have and removed P3 keeping somebody waiting possibly labels Jan 31, 2019
@palango
Copy link
Contributor

palango commented Aug 5, 2021

Closed in #1436

@palango palango closed this as completed Aug 5, 2021
@palango palango added this to the Coruscant milestone Aug 5, 2021
@palango palango self-assigned this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:CORE Raiden Network Core Smart Contracts enhancement New feature or request Needs redeployment The issue/PR results in a breaking change in the precompiled data in `contracts.json` ->redeployment P4: good_to_have
Projects
None yet
Development

No branches or pull requests

5 participants