-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce or implement logging framework for the SDK #926
Comments
Looking through the matrix javascript sdk they seem to use https://github.com/pimterry/loglevel |
At the same time we should be able to disable logging when running unit and e2e tests in raiden-ts. Currently, the logging output is more than overwhelming and it's very difficult to spot errors and exceptions. |
Yes I would also argue for disabling logging completely on the CI. The amount of output is certainly overwhelming. |
The CI logging has proven invaluable for me several times on test failures. I'd argue the perfect approach would be to somehow get jest/CI to keep logs, but show them only for failed tests instead of everything. |
There is this issue for that jestjs/jest#4156 but it seems to have been closed. |
|
Description
This is a proposal about improving and making the logging in the SDK more manageable.
It could be done by either using some popular framework (well maintained and tested) or by writing our own utility to properly handle logging in the SDK.
The major issue with our current approach comes from the fact that there are two different classes of logging:
Everything that is logged by the first class of loggers is easy to manage and turn off when logging is not needed.
For the second category, there is no easy way to currently turn them off and they always appear in the console. While this can be sometimes useful for debugging purposes the verbosity of the messages can be sometimes a bit overwhelming.
After deciding what direction we will follow in regards to logging it is important to decide on log levels for each
console.log
call in the SDK codebase. So messages like the signature messagesSigning x Message
can be atinfo
log level for example.Acceptance criteria
Tasks
console.log
entriesThe text was updated successfully, but these errors were encountered: