Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for redux 4.0.4 & typescript 3.7 #684

Closed
andrevmatos opened this issue Dec 5, 2019 · 0 comments · Fixed by #718
Closed

Workaround for redux 4.0.4 & typescript 3.7 #684

andrevmatos opened this issue Dec 5, 2019 · 0 comments · Fixed by #718
Assignees
@andrevmatos
Labels
sdk 🖥

Comments

@andrevmatos
Copy link
Contributor

Description

Redux has been rewritten in TypeScript, but they didn't yet release a version after this. Last release is 4.0.4 from july, and after this, several fixes landed on their master, including changes for the DeepPartial generic type, which has been giving us issues with our RaidenState type.

We should look for a workaround for this DeepPartial issue, to try to upgrade our TypeScript requirement to 3.7, which includes serveral improvements and some of them can even help us reduce cognitive complexity in our codebase, e.g. the null coalescing operator

Acceptance criteria

Tasks

  • [ ]
@christianbrb christianbrb added this to the Product Backlog milestone Dec 6, 2019
@andrevmatos andrevmatos mentioned this issue Dec 11, 2019
Merged
@andrevmatos andrevmatos removed this from the Product Backlog milestone Dec 12, 2019
@andrevmatos andrevmatos self-assigned this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrevmatos andrevmatos

Labels
sdk 🖥
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade typescript to 3.7 raiden-network/light-client
2 participants
@andrevmatos @christianbrb