Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LC uses online valid registered PFSs for presences even if they're operating on another network, causing offline presence responses #3100

Closed
andrevmatos opened this issue Apr 12, 2022 · 1 comment
Assignees
Labels
bug 🕷️ Something isn't working infrastructure 🚧 Tests, CI, and general project infrastructure sdk 🖥

Comments

@andrevmatos
Copy link
Contributor

Steps to Reproduce

  1. stable/v2 SDK with PFS in auto mode (e.g. hosted instance at https://lightclient.raiden.network)
  2. Go to goerli (which uses v0.40 goerli_unstable contracts)
  3. It'll pick up valid (on registry deposit) PFSs, and when trying to check availability of a peer, use the first registered and online one, even if it's not operating on the same TokenNetworkRegistry
  4. Any registered PFS is offline or not replying properly, it's bypassed; but if the PFS is in fact online, it'll be used for presence; if it happens that this PFS is registered, online but working on a different network, it'll always reply that peers are offline

Notice that this error is caused by infrastructure misconfiguration, but the client must do better to identify this case and find valid services nonetheless.

Expected Result

  • Only a PFS which is registered, valid, online and operating on the same TNR as the node is picked for requests (including presence and route)

Actual Result

  • PFSs which are registered, valid and online, but not on the same TNR, may be picked up, and will prevent the node from getting consistent responses, instead getting always-offline-peer replies or no route found;

Additional Infos (Optional)

Current stable (latest v2.1.0) and master (arbitrum development branch) are affected

@andrevmatos andrevmatos added bug 🕷️ Something isn't working sdk 🖥 infrastructure 🚧 Tests, CI, and general project infrastructure labels Apr 12, 2022
@andrevmatos andrevmatos self-assigned this Apr 12, 2022
@andrevmatos andrevmatos changed the title LC uses online valid registered PFSs for presences even if they're operating on another network, causing offline nodes LC uses online valid registered PFSs for presences even if they're operating on another network, causing offline presence responses Apr 12, 2022
@andrevmatos
Copy link
Contributor Author

Fixed in #3101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🕷️ Something isn't working infrastructure 🚧 Tests, CI, and general project infrastructure sdk 🖥
Projects
None yet
Development

No branches or pull requests

1 participant