Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better inform user about deposit limits in the contract #302

Closed
kelsos opened this issue Sep 2, 2019 · 2 comments
Closed

Better inform user about deposit limits in the contract #302

kelsos opened this issue Sep 2, 2019 · 2 comments
Labels

Comments

@kelsos
Copy link
Contributor

kelsos commented Sep 2, 2019

Description

Currently, if the user tries to deposit a bigger amount than the limit. The deposit transaction will fail and a really unhelpful will be displayed. In the newer contracts, the limits are set during the deployment.

If we can actually read a TokenNetwork's deposit limit then it would be better to check before calling deposit. This way we can stop a failing onchain transaction and also provide a more user-friendly message.

This should be done after upgrading to the Alderaan contracts.

Acceptance criteria

  • Fail before calling the deposit function
  • Show a more meaningful message

Tasks

  • [ ]

Story Points

@christianbrb christianbrb added this to the Product Backlog milestone Sep 5, 2019
@christianbrb christianbrb added the enhancement New feature or request label Sep 5, 2019
@christianbrb
Copy link
Contributor

CC @MrCleanerPickerUpper This is a follow-up issue on your reported issue #298

@christianbrb christianbrb changed the title Better inform user about deposit limits Better inform user about deposit limits in the contract Nov 29, 2019
@christianbrb christianbrb removed this from the Product Backlog milestone Apr 2, 2020
@taleldayekh
Copy link
Contributor

It is very unlikely that a user runs into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants