Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I do want to be able to type an eg. .5 instead of a 0.5 #300

Closed
christianbrb opened this issue Sep 2, 2019 · 5 comments · Fixed by #1219
Closed

I do want to be able to type an eg. .5 instead of a 0.5 #300

christianbrb opened this issue Sep 2, 2019 · 5 comments · Fixed by #1219
Assignees
Labels
dApp 📱 enhancement New feature or request

Comments

@christianbrb
Copy link
Contributor

User Story

As Chris I do want to be able to just type an eg. .5 instead of a 0.5 so that I am faster entering the payment amount

After typing in a number I have to put a whole number (1,2,3,4...) before it allows me to put a decimal place. I.e. I cannot just put .5, i have to put 3.5 then delete the 3.

Acceptance criteria

Tasks

cc @MrCleanerPickerUpper

@nephix
Copy link
Contributor

nephix commented Mar 20, 2020

Built-in in <input type="number" />, only need to switch to that in AmountInput component

@kelsos
Copy link
Contributor

kelsos commented Mar 20, 2020

@nephix Basically the reason the field is not a number, is that Firefox has an issue handling more than 16 decimal points on the type="number", and people were complaining about that on the WebUI so I decided to avoid the issue here. :)

It is only a display issue, the value is still there, but it is confusing.

@nephix
Copy link
Contributor

nephix commented Mar 20, 2020

I didn't know that, how ugly! Thanks for noticing and mentioning

@christianbrb
Copy link
Contributor Author

Considering this would the implementation be more complex than 1 story point?

@nephix
Copy link
Contributor

nephix commented Mar 24, 2020

No, max 2. But I will need to address this within #1160 because they are related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dApp 📱 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants