Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp/SDK: Prevent Light Client from entering a closing state when user closes a channel but rejects MetaMask prompt #2963

Closed
taleldayekh opened this issue Oct 4, 2021 · 0 comments · Fixed by #2967
Assignees
Labels

Comments

@taleldayekh
Copy link
Contributor

User Story

As Chris I want my wallet confirmation, e.g. MetaMask to be the final say in whether a channel closing should happen or not.

While doing user testing it became obvious that in a real world use-case a user familiar with rejecting transactions in their wallet expects to be able to do so when using the LC as well despite the confirmation dialogs in the dApp.

We should make adjustments to better meet the users expectations in this case and not put the channels in a unusable state when a channel close is not actually happening.

Since MetaMask in this case is the last confirmation step it makes sense that it should be the final say on whether a channel enters a closing state or not.

Acceptance criteria

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants