Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CLI should be able to accept paths on /payments request #2949

Closed
andrevmatos opened this issue Sep 15, 2021 · 0 comments · Fixed by #2950
Closed

Feature: CLI should be able to accept paths on /payments request #2949

andrevmatos opened this issue Sep 15, 2021 · 0 comments · Fixed by #2950
Assignees
Labels
cli 🔤 Command-line SDK-based Node.js Client issues feature parity ⚖️ Needed for feature parity with the Raiden Python client feature

Comments

@andrevmatos
Copy link
Contributor

andrevmatos commented Sep 15, 2021

User Story

As Chris, I want to be able to provide a specific route, presence and fee information to the CLI's /payments endpoint, that I managed to construct on my own, and skip SDK from fetching/paying for an automatic request to PFS on its own. It's my problem how to get this data.

The client should be able to receive the paths in this format:

{
  "paths": [
    {
       "route": [<checksum_address>, …],
       "address_metadata": {
          <checksum_address>: <address_metadata>,
          
      },
      "estimated_fee": <optional fee int>
    }, 
  ]
}

Acceptance criteria

  • User can provide its own paths member to CLI's /payments endpoint.

Tasks

@andrevmatos andrevmatos added cli 🔤 Command-line SDK-based Node.js Client issues feature parity ⚖️ Needed for feature parity with the Raiden Python client feature labels Sep 15, 2021
@andrevmatos andrevmatos self-assigned this Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli 🔤 Command-line SDK-based Node.js Client issues feature parity ⚖️ Needed for feature parity with the Raiden Python client feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant