Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test direct and mediated transfers on Arbitrum #2915

Closed
taleldayekh opened this issue Aug 27, 2021 · 1 comment
Closed

Test direct and mediated transfers on Arbitrum #2915

taleldayekh opened this issue Aug 27, 2021 · 1 comment
Assignees
Labels
Rollups ⭕ test Tests related issues

Comments

@taleldayekh
Copy link
Contributor

Description

Acceptance criteria

Tasks

  • [ ]
@taleldayekh taleldayekh added test Tests related issues Rollups ⭕ labels Aug 27, 2021
@taleldayekh taleldayekh added this to the Product Backlog milestone Aug 27, 2021
@taleldayekh taleldayekh removed this from the Product Backlog milestone Sep 3, 2021
@andrevmatos andrevmatos self-assigned this Oct 12, 2021
@andrevmatos
Copy link
Contributor

I did test transfers after #2913 , and all works well. Only issue was when using dApp, on which Metamask has the tendency of caching the blockNumber, and therefore on fast blockchains as Arbitrum (which can produce batches of blocks instantly and/or on quick bursts), it can be outdated for some seconds, making transfers be dropped on the receiving side as it'd already be inside the danger zone. The fix is to either (or both) fix this Metamask block caching, or calculate reasonable timeout parameters considering the fast pace of blocks production, specially for transfer timeout (blocks margin before danger zone), withdraws and settle timeouts.
But this should be just a matter of tweaking the parameters, client and logic should be solid, therefore I'm considering this issue as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rollups ⭕ test Tests related issues
Projects
None yet
Development

No branches or pull requests

2 participants