Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CLI easily installable #2789

Closed
2 of 5 tasks
palango opened this issue Jun 7, 2021 · 4 comments · Fixed by #2802
Closed
2 of 5 tasks

Make CLI easily installable #2789

palango opened this issue Jun 7, 2021 · 4 comments · Fixed by #2802
Assignees
Labels
cli 🔤 Command-line SDK-based Node.js Client issues

Comments

@palango
Copy link
Contributor

palango commented Jun 7, 2021

User Story

As Chris, I want an easy way to install and use the light clients CLI. Ideally I just need to install a raiden-cli package and then can run it with the same parameters as the PC provides with npx raiden-cli

Acceptance criteria

  • Be able to install and run the CLI with the minimum amount of hassle
  • Have this documented

Tasks

  • Decide on a name for that package
  • Build and publish package on npm
    • Check changelog, version bumping, ...
    • Extend CircleCI config to upload package
  • Document installation/usage
@palango palango added the cli 🔤 Command-line SDK-based Node.js Client issues label Jun 7, 2021
@palango palango added this to the Product Backlog milestone Jun 7, 2021
@taleldayekh taleldayekh removed this from the Product Backlog milestone Jun 7, 2021
@weilbith weilbith self-assigned this Jun 10, 2021
@weilbith
Copy link
Contributor

I just discussed with @taleldayekh that do not want to release the old v0.16.0 tag, but just do it when we make the next release together with the raiden-ts package.

@weilbith
Copy link
Contributor

Version bumping is working for all workspaces in the repository already. Nothing to do there.

The CHANGELOG does also exist and is up-to-date. It gets maintained together with all other CHANGELOGs.

@weilbith
Copy link
Contributor

weilbith commented Jun 10, 2021

For the naming I would say we have one: raiden-cli
Though I'm not too happy with it, it is used everywhere all other the place. The package like that basically exists already for a while. Just that is was never uploaded to this specific package registry. So I would not "break" it now.

@taleldayekh any opinion on that?


Edit:
We three had a talk in person and agreed on the above argumentation.

@weilbith
Copy link
Contributor

The open points except the naming have been addressed in the above linked PR. I'm still thinking of testing it with a private registry repository. But in worst case it is as usual: do the sh** manually if it fails in CI. 🤷🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli 🔤 Command-line SDK-based Node.js Client issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants