slist: rewrite slist_delete() #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation had a serious flaw: the loop used **start as iteration variable and changed it, so before each return we would have to make sure it was set exactly right. Now we use a local iteration variable and only touch **start and **last if necessary. Additionally the memory of the deleted element is freed now. This was not done before, but after removing the item from the list, there was no way to ever release this memory anymore: memory leak! The new implementation was tested with unit tests in a personal branch. Fixes rafaelsteil#23. Tested-by: Alexander Dahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation had a serious flaw: the loop used
**startasiteration variable and changed it, so before each return we would have
to make sure it was set exactly right. Now we use a local iteration
variable and only touch
**startand**lastif necessary.Additionally the memory of the deleted element is freed now. This was
not done before, but after removing the item from the list, there was no
way to ever release this memory anymore: memory leak!
This should also fix #23.