Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one env var for DB connections #7

Closed
rafaelespinoza opened this issue Apr 6, 2021 · 1 comment
Closed

Use one env var for DB connections #7

rafaelespinoza opened this issue Apr 6, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@rafaelespinoza
Copy link
Owner

what

Update the drivers to use one environment variable (DB_DSN) to connect to the DB.

why

The current way that DB connection strings are formed is pretty inflexible. It makes assumptions about how the DB is set up on the host system. For instance, it may be easier to not require ssl if it's a CI or development environment. The DB may connect over a socket instead of a TCP connection.

Also, it's a lot easier to manage one environment variable, rather than 5 (DB_HOST, DB_NAME, etc).

@rafaelespinoza rafaelespinoza added bug Something isn't working enhancement New feature or request labels Apr 6, 2021
@rafaelespinoza
Copy link
Owner Author

Fixed in 1dc54d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant