Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/find port #427

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Feature/find port #427

merged 2 commits into from
Nov 26, 2024

Conversation

andre-merzky
Copy link
Member

when auto-assigning port numbers, use 10,000 as starting point to scan for free ports.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.57%. Comparing base (c4b0c1d) to head (0f04852).
Report is 3 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/zmq/pipe.py 66.66% 3 Missing ⚠️
src/radical/utils/zmq/utils.py 76.92% 3 Missing ⚠️
src/radical/utils/heartbeat.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #427      +/-   ##
==========================================
+ Coverage   61.54%   61.57%   +0.03%     
==========================================
  Files          62       62              
  Lines        6974     6980       +6     
==========================================
+ Hits         4292     4298       +6     
  Misses       2682     2682              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-merzky andre-merzky merged commit 53b6316 into devel Nov 26, 2024
11 checks passed
@andre-merzky andre-merzky deleted the feature/find_port branch November 26, 2024 22:45
@mtitov
Copy link
Collaborator

mtitov commented Nov 26, 2024

@andre-merzky confirming that this was tested in RP CI runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants