Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/simple hb #420

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Feature/simple hb #420

merged 7 commits into from
Oct 16, 2024

Conversation

andre-merzky
Copy link
Member

Implement a much simpler process watcher than what is used in RP atm. This will support the airflow executor in ScaleMS.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 45 lines in your changes missing coverage. Please review.

Project coverage is 61.53%. Comparing base (8f767b8) to head (0db3f0f).
Report is 8 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/heartbeat.py 26.78% 41 Missing ⚠️
src/radical/utils/zmq/bridge.py 25.00% 3 Missing ⚠️
src/radical/utils/logger.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #420      +/-   ##
==========================================
- Coverage   61.84%   61.53%   -0.31%     
==========================================
  Files          62       62              
  Lines        6903     6965      +62     
==========================================
+ Hits         4269     4286      +17     
- Misses       2634     2679      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/radical/utils/heartbeat.py Outdated Show resolved Hide resolved
src/radical/utils/heartbeat.py Outdated Show resolved Hide resolved
src/radical/utils/heartbeat.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@andre-merzky andre-merzky merged commit 2a4de17 into devel Oct 16, 2024
10 checks passed
@andre-merzky andre-merzky deleted the feature/simple_hb branch October 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants