Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support for extension like .glsl3, frag3, etc #65

Open
airfortech opened this issue Sep 11, 2024 · 0 comments
Open

[Feature]: Support for extension like .glsl3, frag3, etc #65

airfortech opened this issue Sep 11, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@airfortech
Copy link

airfortech commented Sep 11, 2024

Feature details

There are many problems with Three.js using glsl3 and plugin, f.e. you cant just add # version 300 es to shader code, because it throws error:

1: #define SHADER_TYPE RawShaderMaterial
  2: #define SHADER_NAME 
> 3: # version 300 es

Implementation just adds first line of code as third.
Without # version 300 es i cant use 3.0 syntax.
Workaround would be adding support for extensions like .glsl3, .frag3, .vert3, so when using it, plugin would know shader is using 3.0 without neccessary to put # version 300 es in shader file allowing to use 3.0 syntax.

Other workaround is recognition of // # version 300 es as # version 300 es

@airfortech airfortech added the enhancement New feature or request label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants