Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix exception pickling (cause of TypeError => BrokenProcessPool). #2405

Open
sam-fakhreddine opened this issue Jun 28, 2024 · 2 comments · May be fixed by #2669
Open

[BUG] Fix exception pickling (cause of TypeError => BrokenProcessPool). #2405

sam-fakhreddine opened this issue Jun 28, 2024 · 2 comments · May be fixed by #2669
Assignees
@mbordash2
Labels
bug Something isn't working priority:low Low priority issue or pull request status:accepted Issue or pull request accepted by maintainer

Comments

@sam-fakhreddine
Copy link
Contributor

Description: [BUG] Fix exception pickling (cause of TypeError => BrokenProcessPool).
@sam-fakhreddine sam-fakhreddine added the bug Something isn't working label Jun 28, 2024
@ITProKyle ITProKyle added status:accepted Issue or pull request accepted by maintainer priority:low Low priority issue or pull request labels Jul 18, 2024
@mbordash2
Copy link
Contributor

@ITProKyle to fix one as an example.

@ITProKyle ITProKyle moved this to Backlog in Runway Development Work Sep 4, 2024
@ITProKyle ITProKyle moved this from Backlog to To do in Runway Development Work Sep 4, 2024
@ITProKyle
Copy link
Collaborator

Heres an example of what needs to be done for all custom exceptions in the runway codebase:

  1. All arguments must be positional.
  2. If more than one argument is accepted, a __reduce__ method must be added (example __reduce__ method plus a unit test for the exception).

The base classes RunwayError and CfnginError are fine as written.

@mbordash2 mbordash2 self-assigned this Nov 20, 2024
@mbordash2 mbordash2 linked a pull request Nov 20, 2024 that will close this issue
Draft
7 tasks
@mbordash2 mbordash2 linked a pull request Nov 20, 2024 that will close this issue
custom base exceptions updated for pickling #2669
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbordash2 mbordash2

Labels
bug Something isn't working priority:low Low priority issue or pull request status:accepted Issue or pull request accepted by maintainer
Projects
Runway Development Work
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

custom base exceptions updated for pickling rackspace/runway
3 participants
@sam-fakhreddine @ITProKyle @mbordash2