Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the default request environment be HTTP/1.0? #300

Closed
tenderlove opened this issue May 25, 2022 · 2 comments
Closed

Should the default request environment be HTTP/1.0? #300

tenderlove opened this issue May 25, 2022 · 2 comments

Comments

@tenderlove
Copy link
Member

tenderlove commented May 25, 2022 •
edited
Loading

Looks like the Action Pack tests assumed that the default environment was HTTP/1.1. a68ea95 made it explicitly HTTP/1.0. Should that be the default? I guess it's possible there are HTTP/1.0 clients out there, but I'd guess the vast majority of real world cases are HTTP/1.1.

Anyway, I can fix this upstream in Rails, but I'm not sure if HTTP/1.0 is a sensible default.

@jeremyevans what's your opinion on this?
@tenderlove tenderlove changed the title Default request environm Should the default request environment be HTTP/1.0? May 25, 2022
@jeremyevans
Copy link
Contributor

This was to work around the fact that some software will return Transfer-Encoding: chunked responses, and rack-test does not have a decoder for that. Users that want to force HTTP/1.1 can do so by using env. See #274 and #288 for details.

@tenderlove
Copy link
Member Author

Great, makes sense!

@hannahramadan hannahramadan mentioned this issue Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tenderlove @jeremyevans