Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore window minimum sizes #95

Closed
raboof opened this issue May 10, 2019 · 1 comment
Closed

Ignore window minimum sizes #95

raboof opened this issue May 10, 2019 · 1 comment
Assignees
@raboof
Labels
enhancement LGPL Issues only present on the lgpl branch

Comments

@raboof
Copy link
Owner

raboof commented May 10, 2019

Frames have a minimal size that depends on the windows inside of the frame - even those that are not currently visible. Presumably the windows announce a minimum size and we honor that request.

I think we should ignore the minimum sizes announced by the windows, and give the users the flexibility to make the frames as small as they like.
@raboof raboof added the LGPL Issues only present on the lgpl branch label May 10, 2019
@raboof raboof self-assigned this May 21, 2019
@raboof
Copy link
Owner Author

raboof commented Jun 11, 2019

On closer examination it looks like the fact minimum sizes were ignored on master was a bug, and the lgpl branch doesn't have the bug.

There is already a way to disable it as well, using winprops:

defwinprop{
        ignore_min_size = true,
}

The only limitation is that like this, it won't work for windows that have other winprops.

raboof added a commit that referenced this issue Jun 13, 2019
@raboof
Ignore minimum client window sizes by default (#95)
7e542bc 
This has been the behaviour on Notion 3 for a while, but as far as I can see
unintentionally.

This changes brings that behavior to Notion 4, except neatly through the
default client window flags, and adds the possibility to turn it back on
through winprops.
@raboof raboof mentioned this issue Jun 13, 2019
Merged
raboof added a commit that referenced this issue Jun 17, 2019
@raboof
Ignore minimum client window sizes by default (#95) (#110)
02ae91a 
This has been the behaviour on Notion 3 for a while, but as far as I can see
unintentionally.

This changes brings that behavior to Notion 4, except neatly through the
default client window flags, and adds the possibility to turn it back on
through winprops.
@raboof raboof closed this as completed Jun 18, 2019
@raboof raboof mentioned this issue Jun 18, 2019
Closed
@raboof raboof mentioned this issue Jul 9, 2019
Closed
@raboof raboof mentioned this issue Jan 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raboof raboof

Labels
enhancement LGPL Issues only present on the lgpl branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raboof