Fix wrong extern declaration of pidsToWatch #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Thanks! And thanks to @DiedByDisgust for the review in #230 (comment) ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug
Since pidsToWatch was declared in the
main.cppfile, compilations which uses only the headers have an undefined symbol.I have just moved the definition to the
process.cppclass, which will be included in all binaries.Checks
I am not sure how to check to reproduce the error from #230
I have run:
make&make libnethogswhich compiled successfullyIf you have another way to test the, I would be glad to learn