Fix compilation error with [-Werror=format-security] #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with [-Werror=format-security] in Debian packaging occurs this error:
```
cui.cpp: In function ‘void show_ncurses(Line**, int)’:
cui.cpp:377:73: error: format not a string literal and no format arguments [-Werror=format-security]
377 | mvprintw(3 + 1 + i, cols - COLUMN_WIDTH_UNIT, desc_view_mode[viewMode]);
| ^
cui.cpp:379:29: warning: zero-length gnu_printf format string [-Wformat-zero-length]
379 | mvprintw(totalrow + 1, 0, "");
| ^~
```
This patch solve the problem.
[]'s
kretcheu
raboof
approved these changes
Oct 11, 2021
| @@ -374,9 +374,9 @@ void show_ncurses(Line *lines[], int nproc) { | |||
| int totalrow = std::min(rows - 1, 3 + 1 + i); | |||
| mvprintw(totalrow, 0, " TOTAL %-*.*s %-*.*s %11.3f %11.3f ", | |||
| proglen, proglen, "", devlen, devlen, "", sent_global, recv_global); | |||
| mvprintw(3 + 1 + i, cols - COLUMN_WIDTH_UNIT, desc_view_mode[viewMode]); | |||
| mvprintw(3 + 1 + i, cols - COLUMN_WIDTH_UNIT, "%s", desc_view_mode[viewMode]); | |||
| attroff(A_REVERSE); | ||
| mvprintw(totalrow + 1, 0, ""); | ||
| mvprintw(totalrow + 1, 0, "%s", ""); |
There was a problem hiding this comment.
Kinda weird, isn't there another way that would avoid the warning but not make things unnecessarily more complicated? Anyway, OK I guess ;)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with [-Werror=format-security] in Debian packaging occurs this error:
This patch solve the problem.
[]'s
kretcheu