Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send www-authenticate header when basic auth present but it's wrong #3205

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

deadtrickster
Copy link
Contributor

@deadtrickster deadtrickster commented Jul 20, 2021

Proposed Changes

Send the www-authenticate header as per RFC.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #3181

@deadtrickster deadtrickster marked this pull request as draft July 20, 2021 19:31
@deadtrickster deadtrickster force-pushed the send-www-authenticate-when-basic-auth-present branch from d8214c4 to 39693cf Compare July 20, 2021 19:45
@deadtrickster deadtrickster marked this pull request as ready for review July 20, 2021 19:47
@essen

This comment has been minimized.

Copy link
Contributor

@lhoguin lhoguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadtrickster deadtrickster merged commit 53d67fd into master Jul 21, 2021
@deadtrickster deadtrickster deleted the send-www-authenticate-when-basic-auth-present branch July 21, 2021 09:19
@lhoguin
Copy link
Contributor

lhoguin commented Jul 21, 2021

It should probably be backported to v3.8.x and v3.9.x.

michaelklishin pushed a commit that referenced this pull request Jul 21, 2021
…ic-auth-present

Send www-authenticate header when basic auth present but it's wrong

(cherry picked from commit 53d67fd)
michaelklishin pushed a commit that referenced this pull request Jul 21, 2021
…ic-auth-present

Send www-authenticate header when basic auth present but it's wrong

(cherry picked from commit 53d67fd)
@michaelklishin
Copy link
Member

Backported to v3.8.x.

@michaelklishin
Copy link
Member

Backported to v3.9.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP API incorrectly returns HTTP 401 response when credentials are present but incorrect
4 participants