Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export user tags as a list #2667

Closed
michaelklishin opened this issue Dec 2, 2020 · 1 comment · Fixed by #2676
Closed

Export user tags as a list #2667

michaelklishin opened this issue Dec 2, 2020 · 1 comment · Fixed by #2676
Assignees
@michaelklishin
Labels
usability
Milestone
3.9.0

Comments

@michaelklishin
Copy link
Member

michaelklishin commented Dec 2, 2020 •
edited
Loading

It is currently exported as a comma-separated list. It would be significantly more convenient to export it as a JSON array. We already do this for virtual host tags, for example.

In order to make this reasonably backwards-compatible we could introduce a new field and/or support both kinds of values for import.
@michaelklishin michaelklishin added this to the 3.8.10 milestone Dec 2, 2020
@michaelklishin michaelklishin self-assigned this Dec 2, 2020
@michaelklishin michaelklishin mentioned this issue Dec 2, 2020
Closed
@michaelklishin michaelklishin modified the milestones: 3.8.10, 3.9.0 Dec 2, 2020
@michaelklishin
Copy link
Member Author

This change would make definitions exported on a newer version fail to import on the older releases. The opposite is not true, older definitions will be imported just fine with a trivial amount of effort. Perhaps this should go into 3.9.0. HTTP API client libraries will need some updating to update both types as well.

michaelklishin added a commit that referenced this issue Dec 9, 2020
@michaelklishin
Support importing users with arrays of tags
e4c37db 
as opposed to a comma-separated binary.

Part of #2667.
michaelklishin added a commit that referenced this issue Dec 9, 2020
@michaelklishin
Export user tags as a list
bcf6ac0 
instead of a comma-separated list in a string.

When importing, both formats are now supported (as of
the previous commit).

Closes #2667.
@michaelklishin michaelklishin mentioned this issue Dec 9, 2020
Merged
11 tasks
michaelklishin added a commit to rabbitmq/hop that referenced this issue Dec 9, 2020
@michaelklishin
UserInfo: support tags in both original and updated formats
100a580 
As of rabbitmq/rabbitmq-server#2667, the format changes from a
comma-separated list in a string to a JSON array.

Pair: @acogoluegnes.
This was referenced Dec 9, 2020
Merged
Merged
acogoluegnes added a commit that referenced this issue Dec 11, 2020
@acogoluegnes
Do not split user tags in management UI
335c7b4 
As they are no longer a comma-separated list in a string.

References #2667
@acogoluegnes acogoluegnes mentioned this issue Dec 15, 2020
Closed
acogoluegnes added a commit to rabbitmq/hop that referenced this issue Dec 15, 2020
@acogoluegnes
Make sure user without tags are deserialized correctly
3aaeba7 
Sets also the JSON utilities in a class in the com.rabbitmq.http.client
package. This allows to make all those classes package protected and
private and usable only from the main Hop package.

References rabbitmq/rabbitmq-server#2667
Fixes #235
@acogoluegnes acogoluegnes mentioned this issue Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

Labels
usability
Projects
None yet
Milestone
3.9.0
Development

Successfully merging a pull request may close this issue.

Definition export: change user tags to a JSON array rabbitmq/rabbitmq-server
1 participant
@michaelklishin