Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purpose of SoftProtocolException #1019

Closed
bollhals opened this issue Feb 21, 2021 · 2 comments · Fixed by #1029
Closed

Purpose of SoftProtocolException #1019

bollhals opened this issue Feb 21, 2021 · 2 comments · Fixed by #1029

Comments

@bollhals
Copy link
Contributor

We have a SoftProtocolException which is abstract, but no derived implementation for it. I was wondering is this a left over (and thus can be removed) or what is the use case for it? 🤔
@michaelklishin
Copy link
Member

In the early days the client as designed after the concepts in the protocol. This represents a [channel-level error](https://www.rabbitmq.com/channels.html#error-handling. If we do not actually use it, it definitely can be removed.

@bollhals
Copy link
Contributor Author

Currently if we do such a soft error (see #1020) the channel is closed by the server and the call (if it is a request) is returning an exception. So there is no need for such an exception for now. If you agree, I'll include the removal in one of my next PR.

@bollhals bollhals mentioned this issue Mar 15, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

split connection, enable nullable and remove SoftProtocolException bollhals/rabbitmq-dotnet-client
2 participants
@michaelklishin @bollhals