Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model.Close does not await CloseAsync #1011

Closed
bollhals opened this issue Jan 30, 2021 · 1 comment
Closed

Model.Close does not await CloseAsync #1011

bollhals opened this issue Jan 30, 2021 · 1 comment
Assignees
Milestone

Comments

@bollhals
Copy link
Contributor

From #1008 comment the model close method ignores the returned task of CloseAsync.

=> No exception on shutdown will be raised for this task, this should be fixed.

@lukebakken lukebakken self-assigned this Dec 28, 2023
@lukebakken lukebakken added this to the 7.0.0 milestone Dec 28, 2023
@lukebakken
Copy link
Contributor

I searched the current 6.x and main code for _ = and this issue does not appear to apply any more.

@lukebakken lukebakken closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants