Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct status reference and stop generating client set all the time #99

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Use the correct status reference and stop generating client set all the time #99

merged 3 commits into from
Apr 7, 2021

Conversation

ChunyiLyu
Copy link
Contributor

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • separate client set generation to its own make target and remove go mod vendor from installing tools
  • add a line to remind contributors to re generate client set when create PRs
  • use cluster.status.binding to get secret name instead of cluster.status.defaultUser.secretReference

Additional Context

@ChunyiLyu ChunyiLyu changed the title Status reference Use the correct status reference and stop generating client set all the time Apr 7, 2021
coro
coro approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@coro coro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question, but shouldn't block you merging.

Makefile Show resolved Hide resolved
@ChunyiLyu ChunyiLyu merged commit 395a272 into main Apr 7, 2021
@ChunyiLyu ChunyiLyu deleted the statusReference branch April 7, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coro coro coro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChunyiLyu @coro