Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping kustomize and client go versions #682

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

DanielePalaia
Copy link
Contributor

Same as rabbitmq/cluster-operator#1436

Upgrading kustomize to V5 (which requires client-go v0.28.1) should solve issues like:
https://github.com/rabbitmq/messaging-topology-operator/actions/runs/6178266133/job/16771204981?pr=676

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

Additional Context

@DanielePalaia DanielePalaia force-pushed the bumping_kustomize_and_client_go_versions branch from 8ad73a6 to f64f162 Compare September 21, 2023 18:19
@DanielePalaia
Copy link
Contributor Author

DanielePalaia commented Sep 21, 2023

Seems also that path: needs to be added before the actual path from kustomize v5
kubernetes-sigs/kustomize#1373

@ChunyiLyu ChunyiLyu merged commit 7a709c2 into main Oct 13, 2023
5 checks passed
@ChunyiLyu ChunyiLyu deleted the bumping_kustomize_and_client_go_versions branch October 13, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants