Allow topology objects to be deleted if cluster deleted #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the finalizer step from failing if the cluster is already down.
coro
commented
Mar 12, 2021
coro
changed the title
ChunyiLyu
reviewed
Mar 15, 2021
ChunyiLyu
reviewed
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if a RabbitmqCluster was deleted prior to a topology object referencing that cluster, any attempts to delete the topology object would fail, due to the finalizer step failing. This was because at the start of every Reconcile, the controller attempts to create a rabbit-hole client to the cluster, which would fail.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
The function which retrieves connection info about the RabbitmqCluster now returns a
NoSuchRabbitmqClusterError, which can be type checked in the Reconcile function, provided the error is wrapped correctly. Any controller which attempts to reconcile a deletion of an object which gets this error can continue with removing the finalizer and ignoring the error creating a rabbit-hole client (the cluster was deleted, so no longer requires the object to be deleted as well).Additional Context
This problem was really getting in the way of my development workflow - if a system test failed, I would have to manually edit the objects to remove their finalizers rather than just
k deleteing them.