Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Getter for ExchangeInfo dto to access ExchangeMessageStats #339

Closed
ekonopaka opened this issue Dec 5, 2022 · 3 comments
Closed

Add Getter for ExchangeInfo dto to access ExchangeMessageStats #339

ekonopaka opened this issue Dec 5, 2022 · 3 comments
Milestone

Comments

@ekonopaka
Copy link
Contributor

ekonopaka commented Dec 5, 2022

When doing a get for rabbitmq exchanges in the client we receive ExchangeInfo.
This is good and comprehensive dto object with lots of information.

However in my particular case I need to access ExchangeMessageStats for some more insights.
But for some reason messageStats is a private field with no getter. ExchangeMessageStats is a public class so I assumed it to have public getter inside ExchangeInfo.

Could you please add this getter to ExchangeInfo.ExchangeMessageStats?

@michaelklishin
Copy link
Member

michaelklishin commented Dec 5, 2022

Pretty sure you mean Hop and not the AMQP 0-9-1 Java client. You are welcome to submit a PR. I can't think of a reason to not expose the stats.

@michaelklishin michaelklishin transferred this issue from rabbitmq/rabbitmq-java-client Dec 5, 2022
@ekonopaka
Copy link
Contributor Author

thanks, yes, hop. I'll make a PR

@acogoluegnes
Copy link
Contributor

Fixed in #340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants