Set 'provider' in default user secret

- follow recommendation on provisioned service binding spec
rabbitmq · Feb 22, 2021 · 32c46ee · 32c46ee
1 parent 2a99e5c
commit 32c46ee
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/internal/resource/default_user_secret.go b/internal/resource/default_user_secret.go
@@ -26,6 +26,7 @@ import (
 
 const (
 	DefaultUserSecretName = "default-user"
+	BindingProvider       = "rabbitmq"
 )
 
 type DefaultUserSecretBuilder struct {
@@ -62,7 +63,10 @@ func (builder *DefaultUserSecretBuilder) Build() (client.Object, error) {
 			Namespace: builder.Instance.Namespace,
 		},
 		Type: corev1.SecretTypeOpaque,
+		// Default user secret implements the service binding Provisioned Service
+		// See: https://k8s-service-bindings.github.io/spec/#provisioned-service
 		Data: map[string][]byte{
+			"provider":          []byte(BindingProvider),
 			"username":          []byte(username),
 			"password":          []byte(password),
 			"default_user.conf": defaultUserConf,

diff --git a/internal/resource/default_user_secret_test.go b/internal/resource/default_user_secret_test.go
@@ -99,6 +99,12 @@ var _ = Describe("DefaultUserSecret", func() {
 				Expect(cfg.Section("").Key("default_user").Value()).To(Equal(string(username)))
 				Expect(cfg.Section("").Key("default_pass").Value()).To(Equal(string(password)))
 			})
+
+			By("setting 'provider' to 'rabbitmq' ", func() {
+				provider, ok := secret.Data["provider"]
+				Expect(ok).NotTo(BeFalse(), "Failed to find key 'provider' ")
+				Expect(string(provider)).To(Equal("rabbitmq"))
+			})
 		})
 	})