From 7d1e1bb1e864fb1bea25968ff2d26155ff1aafe9 Mon Sep 17 00:00:00 2001 From: "Diego H." Date: Sat, 7 Dec 2024 23:34:49 +0100 Subject: [PATCH 1/2] Update tests --- tests/testthat/_snaps/aemet_monthly.md | 41 -------------------------- tests/testthat/test-aemet_monthly.R | 5 ---- 2 files changed, 46 deletions(-) diff --git a/tests/testthat/_snaps/aemet_monthly.md b/tests/testthat/_snaps/aemet_monthly.md index 5b021e66..ee5ea08c 100644 --- a/tests/testthat/_snaps/aemet_monthly.md +++ b/tests/testthat/_snaps/aemet_monthly.md @@ -77,44 +77,3 @@ Condition Error in `aemet_monthly_period_all()`: ! Start year need to be numeric - ---- - - Code - aemet_monthly_period_all(end = "NULL") - Condition - Error in `aemet_monthly_period_all()`: - ! End year need to be numeric - -# aemet_monthly_period - - Code - unique(alll$fecha) - Output - [1] "2010-01" "2010-02" "2010-03" "2010-04" "2010-05" "2010-06" "2010-07" - [8] "2010-08" "2010-09" "2010-10" "2010-11" "2010-12" "2010-13" "2011-01" - [15] "2011-02" "2011-03" "2011-04" "2011-05" "2011-06" "2011-07" "2011-08" - [22] "2011-09" "2011-10" "2011-11" "2011-12" "2011-13" "2012-01" "2012-02" - [29] "2012-03" "2012-04" "2012-05" "2012-06" "2012-07" "2012-08" "2012-09" - [36] "2012-10" "2012-11" "2012-12" "2012-13" "2013-01" "2013-02" "2013-03" - [43] "2013-04" "2013-05" "2013-06" "2013-07" "2013-08" "2013-09" "2013-10" - [50] "2013-11" "2013-12" "2013-13" "2014-01" "2014-02" "2014-03" "2014-04" - [57] "2014-05" "2014-06" "2014-07" "2014-08" "2014-09" "2014-10" "2014-11" - [64] "2014-12" "2014-13" "2015-01" "2015-02" "2015-03" "2015-04" "2015-05" - [71] "2015-06" "2015-07" "2015-08" "2015-09" "2015-10" "2015-11" "2015-12" - [78] "2015-13" "2016-01" "2016-02" "2016-03" "2016-04" "2016-05" "2016-06" - [85] "2016-07" "2016-08" "2016-09" "2016-10" "2016-11" "2016-12" "2016-13" - [92] "2017-01" "2017-02" "2017-03" "2017-04" "2017-05" "2017-06" "2017-07" - [99] "2017-08" "2017-09" "2017-10" "2017-11" "2017-12" "2017-13" "2018-01" - [106] "2018-02" "2018-03" "2018-04" "2018-05" "2018-06" "2018-07" "2018-08" - [113] "2018-09" "2018-10" "2018-11" "2018-12" "2018-13" "2019-01" "2019-02" - [120] "2019-03" "2019-04" "2019-05" "2019-06" "2019-07" "2019-08" "2019-09" - [127] "2019-10" "2019-11" "2019-12" "2019-13" "2020-01" "2020-02" "2020-03" - [134] "2020-04" "2020-05" "2020-06" "2020-07" "2020-08" "2020-09" "2020-10" - [141] "2020-11" "2020-12" "2020-13" "2021-01" "2021-02" "2021-03" "2021-04" - [148] "2021-05" "2021-06" "2021-07" "2021-08" "2021-09" "2021-10" "2021-11" - [155] "2021-12" "2021-13" "2022-01" "2022-02" "2022-03" "2022-04" "2022-05" - [162] "2022-06" "2022-07" "2022-08" "2022-09" "2022-10" "2022-11" "2022-12" - [169] "2022-13" "2023-01" "2023-02" "2023-03" "2023-04" "2023-05" "2023-06" - [176] "2023-07" "2023-08" "2023-09" "2023-10" "2023-11" "2023-12" "2023-13" - diff --git a/tests/testthat/test-aemet_monthly.R b/tests/testthat/test-aemet_monthly.R index c83330c7..80f9c05a 100644 --- a/tests/testthat/test-aemet_monthly.R +++ b/tests/testthat/test-aemet_monthly.R @@ -80,11 +80,6 @@ test_that("aemet_monthly_period", { alll2 <- aemet_monthly_period(st, end = 4000) expect_identical(alll, alll2) - # Others - alll <- aemet_monthly_period(st, start = 2010, end = 2023) - expect_snapshot(unique(alll$fecha)) - - # sf Sys.sleep(0.5) alll_sf <- aemet_monthly_period(st, From 873fa73d582dccaf9babc7ad2d4fd44645d7344e Mon Sep 17 00:00:00 2001 From: "Diego H." Date: Sat, 7 Dec 2024 23:38:58 +0100 Subject: [PATCH 2/2] Update action --- .github/workflows/test-coverage.yaml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/test-coverage.yaml b/.github/workflows/test-coverage.yaml index e5b59004..8d7972da 100644 --- a/.github/workflows/test-coverage.yaml +++ b/.github/workflows/test-coverage.yaml @@ -42,6 +42,16 @@ jobs: covr::to_cobertura(cov) shell: Rscript {0} + + - name: Upload coverage report + uses: codecov/codecov-action@v5 + with: + fail_ci_if_error: false + files: ./cobertura.xml + plugins: noop + disable_search: true + token: ${{ secrets.CODECOV_TOKEN }} + - name: Create Junit Report if: ${{ !cancelled() }} run: | @@ -57,15 +67,6 @@ jobs: file: ./junit.xml token: ${{ secrets.CODECOV_TOKEN }} - - name: Upload coverage report - uses: codecov/codecov-action@v5 - with: - fail_ci_if_error: false - files: ./cobertura.xml - plugins: noop - disable_search: true - token: ${{ secrets.CODECOV_TOKEN }} - - name: Show testthat output if: always() run: |