Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve conatiner workspace instantiation #311

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Sep 13, 2024

Refactor and improvements on the logic for instantiate and populate the workspace Cargo of container chains.

@al3mart al3mart requested a review from AlexD10S September 13, 2024 15:25
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner the Cargo now.
I left a couple of comments to fix

crates/pop-common/src/manifest.rs Outdated Show resolved Hide resolved
crates/pop-common/src/manifest.rs Outdated Show resolved Hide resolved
crates/pop-parachains/templates/container/Cargo.templ Outdated Show resolved Hide resolved
@al3mart al3mart requested a review from AlexD10S September 14, 2024 11:25
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Only thing missing is tests that can be tackled in a separate PR

@al3mart al3mart merged commit 51d562f into al3mart/feat-tanssi-container-chains Sep 16, 2024
@al3mart al3mart deleted the al3mart/wip-improve-conatiner-cargo branch September 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants