Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pallet template (default) #272

Conversation

tsenovilla
Copy link
Contributor

This is a sub-PR of

Following what @brunopgalvao said here: #261 (comment) I updated the current template to be closer to the one proposed in https://github.com/paritytech/polkadot-sdk/blob/master/templates/parachain/pallets/template but with some small modifications.

This gives pop cli an updated template for the command pop new pallet allowing newcomers to generate a default template full of docs, ideal to start learning about FRAME development.

The main PR is still open and will be used to propose the advanced, dynamic mode for pop new pallet

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for contributing to pop-cli.

Closes #260

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (b487422) to head (f2b62bf).

Files Patch % Lines
crates/pop-parachains/src/generator/pallet.rs 0.00% 0 Missing and 1 partial ⚠️
crates/pop-parachains/src/new_pallet.rs 80.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   69.54%   69.53%   -0.02%     
==========================================
  Files          51       51              
  Lines        8341     8344       +3     
  Branches     8341     8344       +3     
==========================================
+ Hits         5801     5802       +1     
  Misses       1591     1591              
- Partials      949      951       +2     
Files Coverage Δ
crates/pop-parachains/src/generator/pallet.rs 36.36% <0.00%> (-3.64%) ⬇️
crates/pop-parachains/src/new_pallet.rs 76.40% <80.00%> (-0.61%) ⬇️

@AlexD10S AlexD10S merged commit 318a788 into r0gue-io:main Aug 2, 2024
17 of 18 checks passed
@tsenovilla tsenovilla deleted the tsenovilla/improve-pallet-template-generation-2 branch August 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants