Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #5

Open
florisvdh opened this issue Nov 10, 2022 · 2 comments
Open

Add unit tests #5

florisvdh opened this issue Nov 10, 2022 · 2 comments

Comments

@florisvdh
Copy link
Member

Since the package may be going to expand substantially (#4), it will be wise to add unit tests as well as automated package checks on different platforms in GH Actions, in order to maintain and guarantee functionality in the future.

Do you agree @elipousson ?
@elipousson
Copy link
Collaborator

Yep! I just added a test with testthat on my fork and added an empty GeoPackage file for testing on. I already use codecov.io on several other packages if you're comfortable with using that here.

@elipousson elipousson mentioned this issue Nov 12, 2022
Open
@florisvdh
Copy link
Member Author

Cool! It would be great if you could add the covr + codecov workflow indeed.

This was referenced Nov 15, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elipousson @florisvdh