Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R version required in DESCRIPTION differs from version specified in expect-doppelganger.R #113

Closed
JSchoenbachler opened this issue Jul 16, 2021 · 0 comments

Comments

@JSchoenbachler
Copy link

The R version required in the DESCRIPTION file is R 3.2.0 -

R (>= 3.2.0)

Meanwhile, the expect_doppleganger function skips test evaluation if it is on any version before R 4.1.0 -
is_graphics_engine_stale <- function() {
getRversion() < "4.1.0"
}

As I understand it, R 3.2.0 is fine to use for the write_svg function, but not for the actual expect_doppleganger function. This was confusing to me until I actually read the source code, since there isn't any mention of it on the documentation site (other than a small blurb in the changelog under the unreleased 0.4.0 version).

I think it would make it more clear if you either updated the DESCRIPTION R version requirement or added a blurb about the R version soft requirement to the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant