Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling of R6 Classes feels a little slow #942

Closed
sebffischer opened this issue Apr 27, 2022 · 1 comment
Closed

Styling of R6 Classes feels a little slow #942

sebffischer opened this issue Apr 27, 2022 · 1 comment

Comments

@sebffischer
Copy link

sebffischer commented Apr 27, 2022

I am not sure exactly how styler works but I think the styling of R6 classes could be sped up and feels a little slow sometimes. I guess the problem is that it all happens in one big R6(...) function call, causing styler to restyle the whole R6 class each time it is formatted. Maybe caching could be somehow be improved here?

@sebffischer sebffischer changed the title Styling of R6 Classes is quite slow Styling of R6 Classes feels a little slow Apr 27, 2022
@lorenzwalthert
Copy link
Collaborator

Caching happens on two levels as explained in the vignette. I agree that it migth be slow for very big objects for that reason. R6 classes might be a good starting point for optimizing, but I think this issue is fundamentally #558, so I suggest to close it as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants