Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-check style on unchanged code #491

Closed
jackwasey opened this issue Apr 12, 2019 · 1 comment
Closed

Don't re-check style on unchanged code #491

jackwasey opened this issue Apr 12, 2019 · 1 comment

Comments

@jackwasey
Copy link

Currently, it seems that every file, is checked regardless of whether it is updated. Would it be reasonable to check file timestamps and cache them either in the package or in a tidy place in the user's home directory, or even $TMP? Or use digest to cache the hashes instead of timestamps? This would save a lot of time for bigger R packages, and make this easier to run styler frequently, or possibly automatically with each git commit (if only to check whether styling is due). Q.v. #467

@lorenzwalthert
Copy link
Collaborator

I think this is a duplicate of #320, which obviously is hard to find. Do you mean the environment variable $TMP? I think that's not a good idea because it is not persistent. In #320, we had digest in mind as well. However, I am not sure what the best place to store this information is. Let's continue in #320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants