Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git integration? #452

Closed
krlmlr opened this issue Dec 14, 2018 · 3 comments
Closed

Git integration? #452

krlmlr opened this issue Dec 14, 2018 · 3 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Dec 14, 2018

For initial cleanup of a new-to-me codebase, I'd like to have an "automatic" mode that applies all scopes from "none" to "tokens" in sequence and creates a commit for each. The commit message would contain the report for each step. We're likely to need git2r, but I don't mind a weak dependency.

Do you think this would fit the scope of this package?

@lorenzwalthert
Copy link
Collaborator

This sounds interesting. In practice, I also iterate over strict if necessary. Personally, I like to edit after styled and then commit, but for the average user, this might be too much work. As far as my experience goes, 99% use the defaults for scope and strict anyways. What interface did you have in mind to make such functionality accessible while upholding consistency with the existing API?

@krlmlr
Copy link
Member Author

krlmlr commented Dec 14, 2018

Maybe:

map_git_commit(tidyverse_style_scopes(), ~ style_pkg(scope = .))

@lorenzwalthert
Copy link
Collaborator

PR welcomed Kirill if you want to work on it, but for me this is not top priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants