Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequences of whitespaces are interpreted as valid tag values #1228

Closed
tzakharko opened this issue May 7, 2021 · 0 comments · Fixed by #1310
Closed

Sequences of whitespaces are interpreted as valid tag values #1228

tzakharko opened this issue May 7, 2021 · 0 comments · Fixed by #1310
Labels
bug an unexpected problem or unintended behavior R6 6️⃣
Milestone
v7.1.3

Comments

@tzakharko
Copy link

Roxygen2 detects missing tag values and produces a warning, however only empty strings "" are currently recognized as empty values. This leads to odd situations where e.g. @include is parsed without any warning.

Example:

text <- "
#' @include   
NULL
"
roxygen2::parse_text(text)
@hadley hadley added bug an unexpected problem or unintended behavior R6 6️⃣ labels Mar 29, 2022
@hadley hadley added this to the v7.1.3 milestone Mar 29, 2022
hadley added a commit that referenced this issue Mar 30, 2022
@hadley
Check if trimmed tag value is empty
ecaec67 
Fixes #1228
@hadley hadley mentioned this issue Mar 30, 2022
Merged
hadley added a commit that referenced this issue Mar 31, 2022
@hadley
Check if trimmed tag value is empty (#1310)
f473436 
Fixes #1228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior R6 6️⃣
Projects
None yet
Milestone
v7.1.3
Development

Successfully merging a pull request may close this issue.

Check if trimmed tag value is empty r-lib/roxygen2
2 participants
@hadley @tzakharko