Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested linter: stop|warning|message(paste(...)) #527

Closed
MichaelChirico opened this issue Oct 1, 2020 · 1 comment
Closed

Suggested linter: stop|warning|message(paste(...)) #527

MichaelChirico opened this issue Oct 1, 2020 · 1 comment
Labels
feature a feature request or enhancement

Comments

@MichaelChirico
Copy link
Collaborator

Partly stylistic, but AFAIK this invocation is just a way to save a few whitespace characters by getting sep=' '.

The downsides:

  • Some cognitive load (two functions vs one)
  • Arguments to paste are not captured as string literals for translation so the package becomes less internationalizable

I will submit a linter for this soon
@MichaelChirico MichaelChirico mentioned this issue Oct 4, 2020
Closed
@russHyde russHyde added the feature a feature request or enhancement label Dec 9, 2020
@MichaelChirico
Copy link
Collaborator Author

This is subsumed by #884 (StopPasteLinter() there, for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: New linter to block stop(paste(...)) calls
2 participants
@MichaelChirico @russHyde