Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_unsorted: new linter, or part of sort_linter() ? #2072

Closed
MichaelChirico opened this issue Aug 10, 2023 · 1 comment · Fixed by #2076
Closed

is_unsorted: new linter, or part of sort_linter() ? #2072

MichaelChirico opened this issue Aug 10, 2023 · 1 comment · Fixed by #2076
Labels
google-linters new-linter

Comments

@MichaelChirico
Copy link
Collaborator

One linter for #884 looks for sort(x) == x and recommends !is.unsorted(x).

Should this be a new linter (e.g. is_unsorted_linter()), or subsumed into the recent sort_linter()?
@AshesITR
Copy link
Collaborator

sort_linter() seems like a good place to aid discoverability.

@MichaelChirico MichaelChirico mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
google-linters new-linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

look for is.unsorted() behavior in sort_linter r-lib/lintr
2 participants
@AshesITR @MichaelChirico